Skip to content

Add non-sensitive order transition audit, endpoint, and tests - #208

Open
smog123 wants to merge 2 commits into
karagozemin:masterfrom
smog123:feat/order-state-audit
Open

Add non-sensitive order transition audit, endpoint, and tests#208
smog123 wants to merge 2 commits into
karagozemin:masterfrom
smog123:feat/order-state-audit

Conversation

@smog123

@smog123 smog123 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This PR adds a read-only, non-sensitive audit of order state transitions:

  • Adds order_transitions table to persist from/to timestamps, optional tx hash, and category.
  • Persists transitions on announce, src/dst lock, secret reveal, and manual status updates.
  • Exposes GET /orders/:id/transitions to retrieve transition summaries.
  • Removes preimage from public order serialization to avoid leaking secrets.
  • Adds tests covering happy-path and refund transitions.

Tests: pnpm --filter @oversync/coordinator test passes locally.

@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

@smog123 is attempting to deploy a commit to the karagoz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

Hey @smog123! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#179 [SCF high] Add coordinator order-state transition audit log summary Link to this issue

ℹ️ Learn more about linking PRs to issues

@karagozemin

Copy link
Copy Markdown
Owner

Thanks for the transition audit PR. I started the review from the karagozemin maintainer account, but this branch is currently not mergeable against latest master.

GitHub reports it as conflicting, and a local merge confirms a conflict in:

coordinator/src/persistence/orders-repo.ts

Please rebase or merge latest master, resolve the conflict, and link the PR body to issue #179 (Closes #179) so Wave tracking is clean. After it is mergeable I can run the coordinator tests/build and review the transition audit behavior.

@karagozemin

Copy link
Copy Markdown
Owner

Thanks for the update. I rechecked again after the latest commit, but the branch is still not mergeable against current master.

A local merge now conflicts in:

coordinator/src/persistence/orders-repo.ts
coordinator/src/services/order-service.ts

Please rebase/merge latest master again and resolve those conflicts. After GitHub reports the PR as mergeable, I can run pnpm --filter @oversync/coordinator test and pnpm --filter @oversync/coordinator build for the transition audit behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants