Fix #3481: 1.21.11: Sound_notify mentions feature seems to be bugged.#3482
Closed
kangobot[bot] wants to merge 1 commit intomasterfrom
Closed
Fix #3481: 1.21.11: Sound_notify mentions feature seems to be bugged.#3482kangobot[bot] wants to merge 1 commit intomasterfrom
kangobot[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix proposed by AI analysis of the linked issue.
Changes
main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/model/SoundNotify.java: Fix mention format losing colors: PlainTextComponentSerializer strips all formatting from the replacement text, so the gold color and hover/click from the Sound_Notify.Format are lost. LegacyComponentSerializer preserves the legacy section-sign colors produced by replaceLegacy().main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/model/SoundNotify.java: Fix entire message losing formatting after mention replacement: PlainTextComponentSerializer.serialize() strips ALL color codes from the message, causing blank/uncolored output. LegacyComponentSerializer preserves the existing formatting.main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/model/SoundNotify.java: Remove unused PlainTextComponentSerializer import since both usages were replaced with LegacyComponentSerializerThis is a draft PR — human review required before merging.