SWE-bench dedicated sandbox pool using the baked OCP image (Plan B Task 4)#128
Merged
Merged
Conversation
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plan B Task 4: a dedicated, OCP-only
swebenchSandbox-CR pool that runs the baked x86_64 image produced by Task 3 (#124), plus a hermetic structural test. Purely additive / off-by-default — nothing selects this pool until Plan C setsKAGENTI_SANDBOX_POOL_SELECTOR=sh.kagenti.io/sandbox-pool=swebench. No changes to the default pool,service.yaml, the OCP overlay,setup-ocp.sh, or any Plan A/B code.What's in it
deploy/knative/swebench-sandbox-pool.yaml— 3 Sandbox CRs (agents.x-k8s.io/v1beta1,swebench-sandbox-0/1/2, nsdefault):image-registry.openshift-image-registry.svc:5000/default/swebench-sandbox:ff962cb83fe5c624-15of15(15 relocated conda envs + 8 bare repo mirrors + git/ripgrep,USER 65532)sh.kagenti.io/sandbox-pool: swebench(distinct from the default pool'sdefault); CR labelapp: sandbox(queryable — issue setup-ocp.sh: AB2 sandbox-pool readiness poll spins full timeout (queries a podTemplate label on the Sandbox CR) #103 selector gotcha)command: ["sleep","infinity"](tools baked, no apk),workingDir: /workspace,imagePullPolicy: IfNotPresent/workspacePVC (a shared pod time-shares many concurrent large-repo worktrees + per-leaf venvs; baked/repos+/opt/miniconda3live in image layers, not the PVC)serviceAccountName: serverless-harness-sandboxbaked in (canonical shape fromoverlays/ocp/patch-sandbox.yaml: pod65532/fsGroup 65532/seccompRuntimeDefault, containerallowPrivilegeEscalation:false/dropALL)packages/knative-server/test/swebench-sandbox-pool.test.ts— hermetic YAML-parse structural test (28 assertions), mirrorsauthbridge-manifests.test.ts; no cluster/kustomize, runs inpnpm -r testCI.Design notes (deviations from the original Kind-centric plan text, recorded)
The baked image is x86_64 and lives only in the OCP internal registry — there is no Kind/
dev.localvariant (this host's Kind is arm64). So the manifest is OCP-native directly: the securityContext + SA are baked into the manifest (not a Kind base +overlays/ocpJSON6902 patch as the default/-ab2pools use), and the image tag is a hardcoded content pin.Live gate (OCP 4.20) — GREEN
Applied to a live cluster: 3 PVCs Bound 50Gi, all 3 pods Ready; in-pod verify confirmed uid
65532,git safe.directory '*', git+ripgrep, 15 env dirs (all relocated pythons run; 11 import numpy, 4 numpy-less as expected), 8 bare repo mirrors,/workspacewritable. Cluster restored to baseline afterward.Assisted-By: Claude Code