-
Notifications
You must be signed in to change notification settings - Fork 569
pss: Make compliant with restricted pss by default #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcofranssen
wants to merge
1
commit into
kagent-dev:main
Choose a base branch
from
marcofranssen:fix-pss-compliant-restricted
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| suite: test grafana-mcp deployment | ||
| templates: | ||
| - deployment.yaml | ||
| - configmap.yaml | ||
| - secret.yaml | ||
| tests: | ||
| - it: should render deployment with default values | ||
| template: deployment.yaml | ||
| asserts: | ||
| - isKind: | ||
| of: Deployment | ||
| - equal: | ||
| path: metadata.name | ||
| value: RELEASE-NAME-grafana-mcp | ||
| - equal: | ||
| path: spec.replicas | ||
| value: 1 | ||
| - hasDocuments: | ||
| count: 1 | ||
|
|
||
| - it: should have correct container name | ||
| template: deployment.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.containers[0].name | ||
| value: grafana-mcp | ||
|
|
||
| - it: should have correct service account name | ||
| template: deployment.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.serviceAccountName | ||
| value: RELEASE-NAME-grafana-mcp | ||
|
|
||
| - it: should have correct container port | ||
| template: deployment.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.containers[0].ports[0].containerPort | ||
| value: 8000 | ||
|
|
||
| # ============================================================================= | ||
| # Security Context Tests | ||
| # ============================================================================= | ||
| - it: should apply default pod security context | ||
| template: deployment.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.securityContext.runAsNonRoot | ||
| value: true | ||
| - equal: | ||
| path: spec.template.spec.securityContext.seccompProfile.type | ||
| value: RuntimeDefault | ||
|
|
||
| - it: should apply default container security context | ||
| template: deployment.yaml | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.containers[0].securityContext.allowPrivilegeEscalation | ||
| value: false | ||
| - contains: | ||
| path: spec.template.spec.containers[0].securityContext.capabilities.drop | ||
| content: ALL | ||
| - equal: | ||
| path: spec.template.spec.containers[0].securityContext.readOnlyRootFilesystem | ||
| value: true | ||
| - equal: | ||
| path: spec.template.spec.containers[0].securityContext.runAsUser | ||
| value: 1000 | ||
| - equal: | ||
| path: spec.template.spec.containers[0].securityContext.runAsGroup | ||
| value: 999 | ||
| - isNull: | ||
| path: spec.template.spec.containers[0].securityContext.seccompProfile | ||
|
|
||
| - it: should allow pod security context override | ||
| template: deployment.yaml | ||
| set: | ||
| podSecurityContext: | ||
| runAsNonRoot: true | ||
| fsGroup: 2000 | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.securityContext.runAsNonRoot | ||
| value: true | ||
| - equal: | ||
| path: spec.template.spec.securityContext.fsGroup | ||
| value: 2000 | ||
|
|
||
| - it: should allow container security context override | ||
| template: deployment.yaml | ||
| set: | ||
| securityContext: | ||
| readOnlyRootFilesystem: false | ||
| runAsUser: 1000 | ||
| asserts: | ||
| - equal: | ||
| path: spec.template.spec.containers[0].securityContext.readOnlyRootFilesystem | ||
| value: false | ||
| - equal: | ||
| path: spec.template.spec.containers[0].securityContext.runAsUser | ||
| value: 1000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it is set at the entire Pod level, which applies it already to all containers in that pod. meaning it would not show up as a separate container context setting.