🐛 Fix GoingToCamp KeyError when listing campgrounds#378
Open
justin-outdoorithm wants to merge 1 commit intojuftin:mainfrom
Open
🐛 Fix GoingToCamp KeyError when listing campgrounds#378justin-outdoorithm wants to merge 1 commit intojuftin:mainfrom
justin-outdoorithm wants to merge 1 commit intojuftin:mainfrom
Conversation
The CAMP_DETAILS API returns regional map data where all entries have
resourceLocationId=None, causing the campground_details dictionary to
only contain {None: <last_entry>}. When _process_facilities_responses
tries to look up the actual facility's resource_location_id, it raises
a KeyError.
This fix uses the rootMapId field that's already present in the
LIST_CAMPGROUNDS API response instead of the broken CAMP_DETAILS lookup.
Changes:
- Add root_map_id field to ResourceLocation class
- Capture rootMapId from LIST_CAMPGROUNDS in _filter_facilities_responses
- Use facility.root_map_id directly in _process_facilities_responses
- Remove unused CAMP_DETAILS API call and campground_details dictionary
Fixes juftin#377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #377 - GoingToCamp provider raises
KeyErrorwhen callingfind_campgrounds()for any recreation area.Root Cause
The
CAMP_DETAILSAPI returns regional map data where all entries haveresourceLocationId=None, causing thecampground_detailsdictionary to only contain{None: <last_entry>}. When_process_facilities_responsestries to look up the actual facility'sresource_location_id, it raises aKeyError.The Fix
The
LIST_CAMPGROUNDSAPI response already containsrootMapIdfor each facility. This fix uses that value directly instead of the brokenCAMP_DETAILSlookup.Changes:
root_map_idfield toResourceLocationclass ingtc_api_responses.pyrootMapIdfromLIST_CAMPGROUNDSin_filter_facilities_responses()facility.root_map_iddirectly in_process_facilities_responses()CAMP_DETAILSAPI call andcampground_detailsdictionaryTesting
Tested locally against all affected recreation areas:
Before (crashes)
After (works)