Conversation
There's an awful lot of these. And no LLM found them.
There was a problem hiding this comment.
Pull request overview
This PR introduces a codespell configuration and applies typo/spelling fixes across libpqxx source, tests, scripts, and documentation to improve textual quality and reduce false positives in future spellchecking.
Changes:
- Add a
.codespellrcwith skip paths and an ignore-word list. - Fix spelling/wording typos across scripts, headers, sources, tests, docs, and NEWS.
- Add a
codespell:ignore-next-linesuppression for a test string that contains words flagged by spellcheckers.
Reviewed changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/lint.sh | Fix typo in error/help text. |
| tools/generate_cxx_checks.py | Spelling fixes in explanatory comments. |
| test/test72.cxx | Fix typo in test comment. |
| test/test26.cxx | Fix typo in test comment. |
| test/test07.cxx | Fix typo in test comment. |
| test/test_range.cxx | Adjust spelling in invalid-input test data. |
| test/test_encodings.cxx | Add codespell suppression for a test sentence. |
| test/test_array.cxx | Fix typos in test comments. |
| test/helpers.hxx | Fix typos in default failure descriptions. |
| src/time.cxx | Fix typo in comment. |
| src/strconv.cxx | Fix typo in comment. |
| src/pipeline.cxx | Fix typo in comment. |
| src/connection.cxx | Fix typo in comment. |
| NEWS | Fix typos in release notes. |
| include/pqxx/zview.hxx | Fix typo in doc comment. |
| include/pqxx/util.hxx | Fix typo in doc comment. |
| include/pqxx/transaction_base.hxx | Fix typos in API documentation. |
| include/pqxx/stream_to.hxx | Fix typo in API documentation. |
| include/pqxx/stream_from.hxx | Fix typo in API documentation. |
| include/pqxx/internal/stream_query.hxx | Fix typo in internal doc comment. |
| include/pqxx/internal/sql_cursor.hxx | Fix typo in internal doc comment. |
| include/pqxx/doc/streams.md | Fix typo in documentation. |
| include/pqxx/doc/parameters.md | Fix typo in documentation. |
| include/pqxx/doc/datatypes.md | Fix typos in documentation. |
| include/pqxx/connection.hxx | Fix typos in API documentation. |
| include/pqxx/blob.hxx | Fix typo in API documentation. |
| examples/simple_queries.cxx | Fix typo in example comment. |
| cxx_features.txt | Fix typo in comment text. |
| configure.ac | Fix typo in comment. |
| configure | Fix typo in generated/configure script comment. |
| config-tests/README.md | Fix typo in documentation. |
| BUILDING-configure.md | Fix typo in build documentation. |
| .codespellrc | Add codespell configuration (skip paths + ignore list). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handy tool that finds typos. Amazing: this seems to be what LLMs are best at, and this tool is much better and much faster at it.
I might make this part of the build, except there's a few places where it insists on complaining about things that aren't typos and aren't appropriate for a suppression in the config. In theory I should be able to write an inline comment to suppress these, but... that doesn't seem to work.