feat: expose physical key events over TCP - #2130
Draft
ksquaring wants to merge 1 commit into
Draft
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PhysicalKeyTCP notification containing the original key name, platform-specific numeric code, andpress/release/repeat/tapstateSubscribePhysicalKeyEventsso delivery is enabled per connection and defaults offphysical-key-eventscapability throughHelloOkWhy
Keyboard overlay, accessibility, and teaching tools cannot observe a key that Kanata intercepts and remaps. Existing
push-msgannotations require manual configuration, whileTapActivatedandHoldActivatedonly cover tap-hold resolution.This provides structured access to the original
defsrcinput without confusing it with remapped output. Because physical keystrokes are sensitive and high-volume, clients must explicitly subscribe and can unsubscribe at any time.User impact
TCP clients can detect support using the
physical-key-eventscapability, subscribe with:{"SubscribePhysicalKeyEvents":{"enabled":true}}and receive events such as:
{"PhysicalKey":{"key":"w","code":17,"state":"press"}}Existing clients receive no physical key traffic unless they opt in.
Validation
cargo test -p kanata-tcp-protocolcargo test -p kanata --features tcp_servercargo check -p kanata_example_tcp_clientcargo clippy -p kanata-tcp-protocol -p kanata -p kanata_example_tcp_client --features tcp_server -- -D warningscargo fmt --allgit diff --checkCloses #1097.