Skip to content

Fix quoting in keyboard matching - #2120

Merged
jtroo merged 1 commit into
jtroo:mainfrom
tarasglek:fix-quoting-in-keyboard-matching
Jul 23, 2026
Merged

Fix quoting in keyboard matching#2120
jtroo merged 1 commit into
jtroo:mainfrom
tarasglek:fix-quoting-in-keyboard-matching

Conversation

@tarasglek

Copy link
Copy Markdown
Contributor

Describe your changes. Use imperative present tense.

Strip surrounding syntax quotes from definputdevices matcher values before matching or parsing them.

Without this fix, I could not match an external keyboard on my Mac using the documented quoted name syntax: the parser retained the literal quote characters. Quoted hash values also failed hexadecimal validation.

Reuse trim_atom_quotes() and add a regression test covering quoted names, vendor/product IDs, and an uppercase quoted hash.

Checklist

  • Add documentation to docs/config.adoc
    • N/A — existing documentation already specifies quoted matcher values
  • Add example and basic docs to cfg_samples/kanata.kbd
    • N/A — this fixes existing syntax rather than adding a new configuration feature
  • Update error messages
    • N/A
  • Added tests, or did manual testing
    • Yes

@jtroo jtroo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtroo
jtroo merged commit 922d414 into jtroo:main Jul 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants