fix: clippy

keyberon/src/layout.rs

@@ -748,13 +748,12 @@ impl<'a, T: std::fmt::Debug> WaitingState<'a, T> {
         let res = match active {
             Ok(active) => {
                 // Chording mode still active, only trigger action if it's unambiguous
-                if let Some(action) = config.get_chord_if_unambiguous(active) {
+                {
+                    let action = config.get_chord_if_unambiguous(active)?;
                     if let Some(coord) = released_coord {
                         self.coord = coord;
                     }
                     (WaitingAction::Tap, action)
-                } else {
-                    return None; // nothing to do yet, we'll check back later
                 }
             }
             Err(active) => {

parser/src/cfg/defcfg.rs

@@ -983,13 +983,7 @@ fn parse_cfg_val_u16(expr: &SExpr, label: &str, exclude_zero: bool) -> Result<u1
     match &expr {
         SExpr::Atom(v) => Ok(str::parse::<u16>(v.t.trim_atom_quotes())
             .ok()
-            .and_then(|u| {
-                if exclude_zero && u == 0 {
-                    None
-                } else {
-                    Some(u)
-                }
-            })
+            .filter(|&u| !(exclude_zero && u == 0))
             .ok_or_else(|| anyhow_expr!(expr, "{label} must be {start}-65535"))?),
         SExpr::List(_) => {
             bail_expr!(

parser/src/cfg/macro.rs

@@ -195,7 +195,7 @@ pub(crate) fn parse_macro_item_impl<'a>(
             let (held_mods, unparsed_str) =
                 parse_mods_held_for_submacro(&acs[0], s).map_err(|mut err| {
                     if err.msg == MACRO_ERR {
-                        err.msg = format!("{}\n{MACRO_ERR}", &e.msg);
+                        err.msg = format!("{}\n{MACRO_ERR}", e.msg);
                     }
                     err
                 })?;

parser/src/cfg/sexpr.rs

@@ -220,7 +220,7 @@ impl SExpr {
 impl std::fmt::Debug for SExpr {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            SExpr::Atom(a) => write!(f, "{}", &a.t),
+            SExpr::Atom(a) => write!(f, "{}", a.t),
             SExpr::List(l) => {
                 let inner =
                     l.t.iter()