Skip to content

fix(parser): reject invalid zippy output mappings - #2112

Merged
jtroo merged 1 commit into
jtroo:mainfrom
ShiroKSH:fix/zippy-mapping-arity
Jul 15, 2026
Merged

fix(parser): reject invalid zippy output mappings#2112
jtroo merged 1 commit into
jtroo:mainfrom
ShiroKSH:fix/zippy-mapping-arity

Conversation

@ShiroKSH

Copy link
Copy Markdown
Contributor

Summary

Reject malformed no-erase and single-output zippychord mappings with parser errors.

Previously, mappings without required output values indexed an empty list and panicked during configuration validation. A no-erase mapping with extra values was also accepted instead of rejected.

Validation

  • cargo test --all --no-default-features
  • cargo test --all
  • cargo clippy --all --no-default-features -- -D warnings
  • cargo clippy --all -- -D warnings
  • cargo fmt --all --check

@ShiroKSH

Copy link
Copy Markdown
Contributor Author

@jtroo We'd appreciate it if you could take a look at this pull request when you have a chance.

@jtroo

jtroo commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Thanks!

@jtroo
jtroo merged commit d785f41 into jtroo:main Jul 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants