Skip to content

Performance improvement#1786

Open
t-takuho wants to merge 4 commits intojspreadsheet:masterfrom
t-takuho:performance_improvement
Open

Performance improvement#1786
t-takuho wants to merge 4 commits intojspreadsheet:masterfrom
t-takuho:performance_improvement

Conversation

@t-takuho
Copy link

Performance improvements:

  • Replace the existing variable check with in expression.
  • Replace the formula dependency chain with a set.

英語に自信がないので、日本語でも記載します。。。
パフォーマンスの改善:

  • 変数の存在チェックをin句で置換
  • 数式の依存関係チェーンをSetで置換

@rangermeier
Copy link
Contributor

This PR removes the usage of eval().
This is not just a performance improvement but also removes a potential security issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants