Skip to content

fix options #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BigBlueHat wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix options #901

BigBlueHat wants to merge 7 commits into from
+23 −46

Conversation

@BigBlueHat
Copy link
Member

@BigBlueHat BigBlueHat commented Dec 16, 2025

  • Fix base URL; simplify UX.
  • Improve Safe Mode error display.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2025 •
edited
Loading

Deploying json-ld-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: a091164
Status: ✅  Deploy successful!
Preview URL: https://2f8f4f7e.json-ld-org.pages.dev
Branch Preview URL: https://fix-options.json-ld-org.pages.dev

View logs

@BigBlueHat
Copy link
Member Author

BigBlueHat commented Dec 17, 2025

Fixes several more items from #896

TallTed
TallTed approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, fwiw

@davidlehn
Copy link
Member

davidlehn commented Dec 17, 2025

  • Safe mode seems to totally not work now. No errors at all, seems to eat them and not update output or log anything.
  • I don't understand the reasoning for the changes here. Seems the behavior is changing rather than fixing what was working before. I know the way it worked was a bit odd, but it was intentional. (And the implementation was awkward mostly because of the old jquery static mess.) The "default" option modes were meant to default to whatever the algorithms would do. Looks like now it's forcing you to choose an option value. How is that going to work to let people see what default behavior is?

@davidlehn
Copy link
Member

davidlehn commented Dec 17, 2025

Clicking more, I see safe mode maybe only works on the compact tab? But not elsewhere? In particular, not at all on the canonized tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TallTed TallTed TallTed approved these changes

@davidlehn davidlehn Awaiting requested review from davidlehn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BigBlueHat @davidlehn @TallTed