Skip to content

Remove unnecessary native code#828

Merged
ThexXTURBOXx merged 4 commits into
jonbhanson:masterfrom
ThexXTURBOXx:remove-native
May 23, 2026
Merged

Remove unnecessary native code#828
ThexXTURBOXx merged 4 commits into
jonbhanson:masterfrom
ThexXTURBOXx:remove-native

Conversation

@ThexXTURBOXx
Copy link
Copy Markdown
Collaborator

@ThexXTURBOXx ThexXTURBOXx commented May 20, 2026

The current native code is just boilerplate code from the initial generated plugin project skeleton.
It's time to remove it now that Flutter actively warns about using non-built-in Kotlin.

Fixes #827
Fixes #831

@adil192
Copy link
Copy Markdown

adil192 commented May 20, 2026

I'm all for removing boilerplate but just to make sure there's no misunderstanding, using built-in kotlin is just referring to removing the id("kotlin-android") line as outlined in https://docs.flutter.dev/release/breaking-changes/migrate-to-built-in-kotlin/for-app-developers

@ThexXTURBOXx
Copy link
Copy Markdown
Collaborator Author

@adil192 I am aware of that - I have correctly migrated a couple of other plugins already :)
However, in this case, the native code is entirely unnecessary. Hence, it is just easier to remove it and avoid future maintenance this way as well

@jonbhanson
Copy link
Copy Markdown
Owner

@Bungeefan do you have authorization to squash and merge, or is that something that I need to do?

@Bungeefan
Copy link
Copy Markdown
Collaborator

@jonbhanson No, I should be able to merge them.
I just wasn't sure if I were supposed to yet (or if @ThexXTURBOXx wanted to do it himself).

@jonbhanson
Copy link
Copy Markdown
Owner

If either of you, or especially both of you, feel confident in a PR, you can feel free to merge and squash then. I actually don't feel like I'm in Flutter enough at this point to be a good judge. I'll be happy to take care of making new releases on pub.dev though. Thanks for your help!

@ThexXTURBOXx
Copy link
Copy Markdown
Collaborator Author

@Bungeefan Thank you for your reviews! I will merge my PRs after I have looked at everything myself again later.

@jonbhanson No problem at all! I/We will let you know when a new release on pub.dev would make sense.

Alas, I don't have an Apple device - hence, I cannot meaningfully review the Apple-focused PRs here :/

@ThexXTURBOXx ThexXTURBOXx merged commit fb3dc86 into jonbhanson:master May 23, 2026
1 check passed
@ThexXTURBOXx ThexXTURBOXx deleted the remove-native branch May 23, 2026 18:16
@ThexXTURBOXx
Copy link
Copy Markdown
Collaborator Author

@jonbhanson I forgot to add a proper changelog and update the version number in the pubspec and README. Currently, I am on my way into vacation.
After that, I will prepare all this stuff and ask you to publish a new release. Sorry about that and thank you already in advance!

@jonbhanson
Copy link
Copy Markdown
Owner

@ThexXTURBOXx no worries, I can take care of the changelog and the version number in the release that I do. I think it will actually work better that way. Just let me know when it's ready and I'll make the update and push the release.

@ThexXTURBOXx
Copy link
Copy Markdown
Collaborator Author

@jonbhanson If you prefer the workflow this way, feel free to push a new release now, actually. I had looked through my changes before my vacation and I am confident in them. Thank you very much!

jonbhanson added a commit that referenced this pull request May 29, 2026
…unnecessary native code. Thanks Nico for PR #828.  Fix remove command always showing help instead of executing. Thanks ersanKolay for PR #823. Fixes #822, #804, #786. Updated dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add a support Swift Package Manager Migrate Plugin to Built-in Kotlin

4 participants