fixed shape mismatch in AdaptiveImageLossFunction - #15
Open
rvarun7777 wants to merge 1 commit into
Open
Conversation
Owner
|
There are unit tests that need to be updated as well. |
Author
|
I could not find an issue in your unit tests. |
Owner
|
I patched your PR and ran nosetests from the root directory, and it causes
the testImageLossfun* tests to fail. Those tests need to also be rewritten
with the same NHWC-> NCHW dimension reordering.
…On Mon, Mar 9, 2020 at 3:40 AM Varun Ravikumar ***@***.***> wrote:
Tested your loss on YUV space on monodepth2 project. It just drives the
final loss below 0.#
AdaptiveImageLossFunction((3, 640, 192), torch.float32, "cuda:0",
color_space='YUV', scale_lo=0.01, scale_init=0.01)
These were the initial setting used.
Final loss = 0.85 Adaptive Loss + 0.15 SSIM + 0.01 Smoothness
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#15?email_source=notifications&email_token=AAGZFNUVPB7HDFIHYYCF5QLRGTBR3A5CNFSM4LD4YMAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOGSF3Q#issuecomment-596452078>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGZFNVMR43AEPPOXYNFGELRGTBR3ANCNFSM4LD4YMAA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.