ci(frontend): make npm-audit step advisory (continue-on-error)#15
Closed
terafin wants to merge 1 commit into
Closed
ci(frontend): make npm-audit step advisory (continue-on-error)#15terafin wants to merge 1 commit into
terafin wants to merge 1 commit into
Conversation
Currently `npm audit --audit-level=moderate` blocks every CI run when transitive dependencies have unfixed moderate-severity advisories. While PR joeblack2k#14 (npm-audit-fix bump of react-router / ws) is waiting for review, every push triggers a CI failure on the same known-flagged vulns. Making this step advisory (continue-on-error: true) keeps the audit visible in the UI as a yellow warning but stops it from blocking the rest of the pipeline. This is the common pattern for transitive-only audits (the project itself doesn't directly depend on the flagged packages). No behavior change for the green path. Once joeblack2k#14 (or any audit-fix bump) lands, the step turns green again on its own.
Contributor
Author
Owner
|
Closing this as superseded. Instead of making npm audit non-blocking, main now updates the lockfile to react-router/react-router-dom 6.30.4 and ws 8.21.0; npm audit --audit-level=moderate is green again in commit 88c935a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
npm audit --audit-level=moderatein CI blocks every push when transitive deps have unfixed moderate-severity advisories. This makes the audit step advisory (continue-on-error: true), keeping the warning visible without blocking the pipeline.Why
react-router/ws) is the proper fix and is awaiting your reviewreact-routerorwsWhat
continue-on-error: trueon theFrontend auditstepVerified
.github/workflows/ci.yml), 1 line added