Fix TypeError on ordering comparison between string and number#347
Open
bysiber wants to merge 1 commit intojmespath:developfrom
Open
Fix TypeError on ordering comparison between string and number#347bysiber wants to merge 1 commit intojmespath:developfrom
bysiber wants to merge 1 commit intojmespath:developfrom
Conversation
Ordering comparators (<, <=, >, >=) check each operand individually
via _is_comparable(), which returns True for numbers OR strings. When
one operand is a string and the other is a number, both pass the check
independently but operator.lt('foo', 5) raises TypeError in Python 3.
The JMESPath spec says ordering comparisons on incompatible types
should return null. Fix by requiring both operands to be the same
comparable type (both numbers or both strings).
This also removes the unused num_types variable that was left over
from an earlier version of this code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordering comparators (
<,<=,>,>=) crash withTypeErrorwhen comparing a string to a number:Per the JMESPath spec, ordering comparisons on incompatible types should return
null.The bug is in
_is_comparable()— it returnsTruefor numbers or strings independently. When one operand is a string and the other is a number, both pass the individual check, butoperator.lt("foo", 5)raisesTypeErrorin Python 3.The fix requires both operands to be the same comparable type (both numbers or both strings). This also removes the unused
num_typesvariable that was left over from before string comparisons were added.