Add new field Image#90
Open
haydenk wants to merge 1 commit intojmcarp:masterfrom
haydenk:master
Open
Conversation
make sure to use the new field when appropriate add tests for new field
NikaOly
approved these changes
Oct 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed to be treating this as a normal input type when it should be treated as like a submit button.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input/image
There is also the slight change when it serializes from just a single field and value to two fields appropriately named with the x, y values of where on the image the user clicked.
Currently, I am not handling there being different x and y values, simply just creating two new fields with
.xand.yappended to the name.