fixed calls to jQuery on() & off event handlers to match ver10.7 syntax#60
Open
furiousgreencloud wants to merge 1 commit into
Open
fixed calls to jQuery on() & off event handlers to match ver10.7 syntax#60furiousgreencloud wants to merge 1 commit into
furiousgreencloud wants to merge 1 commit into
Conversation
Owner
|
@furiousgreencloud thanks for the PR! I'm a little confused, though... what's the version 10.7 you referenced in your commit message? The latest jQuery version is 3.1.1 AFAICT, and the api for |
Author
|
the version 10.7 is a typo, I was trying to reference "version added: 1.7.off( events [, selector ] [, handler ] )" from http://api.jquery.com/off/ |
Owner
|
Gotcha. Do you have an example of where the previous version didn't work and the modified version does? As best I can tell, they should do the same thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this all the "resize" handlers/functions are removed