Skip to content

Adding interaction option allowing user to choose between click and hover functionality#41

Open
lukehillonline wants to merge 2 commits into
jmar777:masterfrom
lukehillonline:master
Open

Adding interaction option allowing user to choose between click and hover functionality#41
lukehillonline wants to merge 2 commits into
jmar777:masterfrom
lukehillonline:master

Conversation

@lukehillonline

Copy link
Copy Markdown

Users can now use the 'interaction' option to choose between having on hover or on click interactions. The default interaction is set to 'hover' and the available options to the user are 'hover' and 'click' this is used like so:

$(function() {
$('.kwicks').kwicks({
interaction: 'click'
});
});

@jmar777

jmar777 commented Mar 27, 2014

Copy link
Copy Markdown
Owner

@lukehillonline Hey, sorry for the delay in responding to this. Haven't had any time to focus on Kwicks recently, but thank you for the pull request! I'll do my best to review this in the near future.

@lukehillonline

Copy link
Copy Markdown
Author

@jmar777 Hey, that's no problem, I love your plugin and it was exactly what I needed for a project, I just needed it to work on click so I thought I would add it in.

This is my first contribution on github so apologies if it is not perfect.

@bekliev

bekliev commented Jul 23, 2014

Copy link
Copy Markdown

@jmar777, well done!

@bekliev

bekliev commented Jul 23, 2014

Copy link
Copy Markdown

@lukehillonline, When will you update library with this interaction option?
And don't forget update the documentation :)

@lukehillonline

Copy link
Copy Markdown
Author

@nightkon Thanks! I don't have permission to update the library and it is owned by @jmar777, so it is down to him when this gets merged. I did forget to update the documentation so I will update this over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants