fix(qos-provisioning): address remaining review comments from #580 - #2
Closed
hdamker wants to merge 3 commits into
Closed
Conversation
…ame collision The local event subtype was named CloudEvent, same as the CAMARA_event_common.yaml envelope it extends via allOf. Bundling renames the common envelope to CloudEvent-2 to resolve the clash, which fails the PascalCase naming rule at release review.
…4.3 marker Section text was present but not bracketed by the mandatory HTML-comment markers, so release review would flag it as missing. Also add a blank line after every BEGIN marker per camaraproject/Commonalities#651 (Swagger Editor/UI doesn't render the heading right after an HTML comment).
…oxy aliases Replace local $ref-only aliases for Device, DeviceResponse, ErrorInfo, SinkCredential, x-correlator param/header, and the Generic4xx/5xx responses with direct refs to CAMARA_common.yaml / CAMARA_event_common.yaml at each use-site, matching the pattern camaraproject#579 settled on. Drop AccessTokenCredential/PrivateKeyJWTCredential (dead, unreferenced) and inline openId/notificationsBearerAuth definitions in favor of $ref to the common file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the remaining points from my review comment on camaraproject#580 (camaraproject#580 (comment)):
CloudEvent/ApiEventTypeschemas to avoid the bundling name collision with the commonCloudEventenvelope.identifying-device-from-access-tokenin the mandatory r4.3 marker (was present but unwrapped); also add a blank line after every BEGIN marker per Markdown immediately after SGML comment is not displayed properly by Swagger editor camaraproject/Commonalities#651.Device,ErrorInfo,SinkCredential,x-correlator,Generic4xx/5xx, ...) and referenceCAMARA_common.yaml/CAMARA_event_common.yamldirectly at each use-site, matching Align quality-on-demand API and tests with Commonalities 0.8.0 (r4.3) camaraproject/QualityOnDemand#579.Details in the individual commits. Feel free to take, adjust, or squash as you see fit.