fix: clamp trig LUT index to prevent OOB reads on close points - #371
Merged
Conversation
sinLUT/cosLUT could index beyond LUT_SIZE when a small angle rounded to 2*PI in float32, making calcDist/calcCourse return garbage for points <~3m apart. This broke simFakeGPS (jumps/ stalls on dense tracks) and corrupted close-range navigation distances, track accumDist and grades. Raise sim track-cut threshold to 50km and derive climb subjects from the interpolated position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sinLUT/cosLUT could index beyond LUT_SIZE when a small angle rounded to 2*PI in float32, making calcDist/calcCourse return garbage for points <~3m apart. This broke simFakeGPS (jumps/ stalls on dense tracks) and corrupted close-range navigation distances, track accumDist and grades.
Raise sim track-cut threshold to 50km and derive climb subjects from the interpolated position.