Fix Connection Test in Job config when job credential is used from folder#1865
Open
mmusenbr wants to merge 1 commit intojenkinsci:masterfrom
Open
Conversation
On the connection test from the folder, the GitLabConnection was initialized with the jobCredentialId, therefore the getClient assumes the system configured credential is the same as the job config credential and only looks in the syste creds store. Fix jenkinsci#1864 Signed-off-by: Michael Musenbrock <michael.musenbrock@gmail.com>
b59446d to
926b21f
Compare
Author
|
Hi, is there anything I could help with, provide something additional, to get this fix in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the connection test from the folder, the GitLabConnection was initialized with the jobCredentialId, therefore the getClient assumes the system configured credential is the same as the job config credential and only looks in the syste creds store.
Fixes #1864
Testing done
I have build the plugin with the changes and deployed it on our Jenkins-Environment.
Before the Change:
AFTER the change
Submitter checklist