Skip to content

Fix for Issue-1140 - cancel running jobs on merge request update when source branch is same#1268

Open
RemigiuszDudek wants to merge 5 commits intojenkinsci:masterfrom
RemigiuszDudek:issue-1140-cancel-running-jobs-on-merge-request
Open

Fix for Issue-1140 - cancel running jobs on merge request update when source branch is same#1268
RemigiuszDudek wants to merge 5 commits intojenkinsci:masterfrom
RemigiuszDudek:issue-1140-cancel-running-jobs-on-merge-request

Conversation

@RemigiuszDudek
Copy link

@RemigiuszDudek RemigiuszDudek commented Mar 26, 2022

No description provided.

@RemigiuszDudek RemigiuszDudek requested a review from a team as a code owner March 26, 2022 09:37
@RemigiuszDudek RemigiuszDudek mentioned this pull request Mar 26, 2022
Open
@RemigiuszDudek RemigiuszDudek force-pushed the issue-1140-cancel-running-jobs-on-merge-request branch 2 times, most recently from 1ca69d6 to 97c932e Compare March 29, 2022 07:54
@RemigiuszDudek RemigiuszDudek force-pushed the issue-1140-cancel-running-jobs-on-merge-request branch from 97c932e to 7d8a8c3 Compare May 15, 2022 13:25
@RemigiuszDudek RemigiuszDudek force-pushed the issue-1140-cancel-running-jobs-on-merge-request branch from 7d8a8c3 to a0a9449 Compare June 15, 2022 09:06
@RemigiuszDudek RemigiuszDudek force-pushed the issue-1140-cancel-running-jobs-on-merge-request branch from a0a9449 to 4467eb9 Compare August 30, 2022 04:22
@RemigiuszDudek RemigiuszDudek changed the title Issue-1140 - cancel running jobs on merge request update when source branch is same Fix for Issue-1140 - cancel running jobs on merge request update when source branch is same Aug 31, 2022
@RemigiuszDudek
Copy link
Author

RemigiuszDudek commented Aug 31, 2022

fixes #1140

@RemigiuszDudek RemigiuszDudek force-pushed the issue-1140-cancel-running-jobs-on-merge-request branch from 4467eb9 to c1dc9b9 Compare October 23, 2022 05:48
MarkEWaite
MarkEWaite requested changes Oct 23, 2022
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think that it is better to leave this decision to the author of the Pipeline and its Jenkinsfile rather than always stopping a previous build when newer changes arrive.

See the disableConcurrentBuilds task as it is used in the Jenkins plugin build process

@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Nov 22, 2022
@dwzg
Copy link

dwzg commented Apr 3, 2023

I don't think disableConcurrentBuilds is an adequate alternative to the functionality from this PR. When multiple Merge Request are triggering the same job, I don't want to just cancel any running build, only those which were triggered from the same MR and are thus outdated. From looking at disableConcurrentBuilds(abortPrevious: true), any running build will be aborted. The GitLab plugin already has this function, but only for pending builds.

@krisstern krisstern closed this Apr 3, 2023
@krisstern krisstern reopened this Apr 3, 2023
@Alena00-1
Copy link

Alena00-1 commented Nov 8, 2024

Good day.
A much needed fix. This is a really cool thing.
When can we expect these fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkEWaite MarkEWaite MarkEWaite requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RemigiuszDudek @dwzg @Alena00-1 @MarkEWaite @krisstern