Conversation
rcrichton
suggested changes
Mar 8, 2024
Contributor
rcrichton
left a comment
rcrichton
left a comment
There was a problem hiding this comment.
Looks good, a few comments.
| networks: | ||
| public: | ||
| default: | ||
| - ${PWD}/configs/clickhouse-keeper-01/etc/clickhouse-keeper/keeper_config.xml:/etc/clickhouse-keeper/keeper_config.xml |
Contributor
There was a problem hiding this comment.
We can't use regular file mount with docker swarm as these files need to be available across all nodes. That is why we use docker config which will make the config available across all nodes.
| mode: host | ||
| - target: 9000 | ||
| published: 9001 | ||
| published: 9000 |
Contributor
There was a problem hiding this comment.
Thank you, been meaning to do this too. This might have implications in other packages. Maybe a quick search will be able to tell if this is the case or not.
| services: | ||
| analytics-datastore-clickhouse: | ||
| image: clickhouse/clickhouse-server | ||
| image: clickhouse/clickhouse-server:latest |
Contributor
There was a problem hiding this comment.
Lets pin this to the latest release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation was inspired from official clickhouse recipes for docker compose.
https://github.com/ClickHouse/examples/tree/main/docker-compose-recipes
This implementation has 3 replicas and 1 shard, it would make sense to have 2 shards if we have 4 nodes. So it would depend on the actual implementation.