AOT support#605
Open
hatulaile wants to merge 7 commits into
Open
Conversation
Migrate from Newtonsoft.Json to System.Text.Json
Author
|
@Shadowghost Should I split this commit into smaller pieces to make the review easier? Or is the change simply too large to be merged in general? (Translated from Chinese using LLM.) |
Contributor
|
I think the biggest issue is testing this reliably. From a code perspective this looks fine, but since this is a big change it'll mandate a new major release once merged. |
Author
|
Yes, I agree. I can't be sure if there are any issues beyond the test cases or if there are any breaking changes. (Translated from Chinese using LLM.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This PR may not be merged as-is.
Due to the large number of changes, there may be some errors.
#594
This PR migrates from
Newtonsoft.JsontoSystem.Text.Json, adding AOT support.Enables AOT analysis.
If this PR is not intended to be merged, please close it. :)