Attach memory.zip on release for download tracking#1
Conversation
HACS installs via source zipball, which GitHub does not count. Set zip_release + filename so HACS pulls an attached asset instead, and add a release workflow that builds and attaches memory.zip on publish. This makes release download_count a real per-version install counter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a release workflow that builds ChangesRelease packaging
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10dfbec607
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "render_readme": true, | ||
| "homeassistant": "2024.10.0" | ||
| "homeassistant": "2024.10.0", | ||
| "zip_release": true, |
There was a problem hiding this comment.
Hide branch installs for zip releases
With zip_release enabled, HACS installs via the configured release asset rather than the repository archive. In the default-branch install path (for HACS versions/UIs that offer it, or when users pass main via the update service), the selected ref is the branch name, so HACS looks for /releases/download/main/memory.zip; this workflow only creates memory.zip for published tag releases. Add hide_default_branch: true or provide a branch-compatible path, otherwise those installs/redownloads fail with a 404.
Useful? React with 👍 / 👎.
Makes HACS install counts trackable via GitHub release
download_count.Why: HACS installs by pulling the source zipball, which GitHub does not count — so
download_countstays 0 forever. Settingzip_release: true+filename: memory.zipmakes HACS download an attached asset instead, and GitHub counts every asset download.Changes:
hacs.json: addzip_release+filename.github/workflows/release.yml: buildmemory.zip(contents ofcustom_components/memory/) and attach it on every published releaseAfter merge, the next published release activates tracking. Query with
gh api repos/jayzuccarelli/ha-memory/releases --jq '.[].assets[]|{name,download_count}'.🤖 Generated with Claude Code
Summary by CodeRabbit
memory.zip.