Fix BPF tests failing because use_task_pt_regs_helper defaults to true#504
Fix BPF tests failing because use_task_pt_regs_helper defaults to true#504gmarler wants to merge 3 commits into
Conversation
|
Now that those tests pass, the following fail: |
- test_integration and test_integration_ocaml_native_defaults: now set use_task_pt_regs_helper from system_info, matching what the production binary does - test_use_pt_regs_helper: returns early on kernels without the helper - test_do_not_use_pt_regs_helper: start with true instead of false
|
With that commit, the integration tests pass again on a live RHEL 8.10 box too. |
| ..ProfilerConfig::default() | ||
| }, | ||
| stop_signal_receive, | ||
| metadata_provider, |
There was a problem hiding this comment.
Why not using ..Profiler::Default() like you did above for the config?
There was a problem hiding this comment.
Oh, that's because here we're not overriding ProfilerConfig::default() (alone) like I did above, but I'm overriding Profiler::default() instead - because that's what the test is using.
And the only way I know of to do that in Rust is not to call Profiler::Default() at all, but to call Profiler::new() with the same ProfilerConfig::default() override as I did above - plus the other arguments Profiler::new() needs.
Am I missing something?
javierhonduco
left a comment
There was a problem hiding this comment.
Minor comments, LGTM overall
true