Skip to content

fix(nzbfs): bind file context to HTTP request context and cancel on close #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DarkseidAM wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix(nzbfs): bind file context to HTTP request context and cancel on close #816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
805d063
fix(nzbfs): bind file context to HTTP request context and reduce serv…
DarkseidAM Aug 9, 2026
bd7d55f
fix(nzbfs): call cancelCtx in MetadataVirtualFile.Close
DarkseidAM Aug 11, 2026
883f2ae
fix(nzbfs): revert WriteTimeout reduction, keep request-bound file co…
DarkseidAM Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/nzbfilesystem/metadata_remote_file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ func (mrf *MetadataRemoteFile) OpenFile(ctx context.Context, name string) (bool,
KnownHoles: fileMeta.KnownHoles,
}

fileCtx, cancel := context.WithCancel(ctx)
// Create a metadata-based virtual file handle
virtualFile := &MetadataVirtualFile{
name: name,
Expand All @@ -279,7 +280,8 @@ func (mrf *MetadataRemoteFile) OpenFile(ctx context.Context, name string) (bool,
padRecorder: mrf.padRecorder,
configGetter: mrf.configGetter,
poolManager: mrf.poolManager,
ctx: ctx,
ctx: fileCtx,
cancelCtx: cancel,
maxPrefetch: maxPrefetch,
rcloneCipher: mrf.rcloneCipher,
aesCipher: mrf.aesCipher,
Expand Down Expand Up @@ -799,6 +801,7 @@ type MetadataVirtualFile struct {
configGetter config.ConfigGetter
poolManager pool.Manager // Pool manager for dynamic pool access
ctx context.Context
cancelCtx context.CancelFunc
maxPrefetch int // Maximum segments prefetched ahead of current read position
rcloneCipher *rclone.RcloneCrypt
aesCipher *aes.AesCipher
Expand Down Expand Up @@ -1490,6 +1493,9 @@ func (mvf *MetadataVirtualFile) Seek(offset int64, whence int) (int64, error) {

// Close implements afero.File.Close
func (mvf *MetadataVirtualFile) Close() error {
if mvf.cancelCtx != nil {
mvf.cancelCtx()
}
// Cancel the in-flight reader before taking mvf.mu — a concurrent
// Read can hold the lock for the full segment-download latency.
mvf.interruptCurrentReader()
Expand Down
Loading