Allow equals signs in values that are set on the fly#557
Open
aaw wants to merge 1 commit intojavan:mainfrom
Open
Allow equals signs in values that are set on the fly#557aaw wants to merge 1 commit intojavan:mainfrom
aaw wants to merge 1 commit intojavan:mainfrom
Conversation
The current code strips everything after the first equals sign in the value of a variable set on the fly. For example, `whenever --set 'a=b=c&d=e'` will set a to 'b' and d to 'e'. I noticed this when trying to pass a base64-encoded value that had trailing equals signs which were all stripped off. This patch fixes this stripping by interpreting everything after the first equals sign in a key-value pair as the value.
olleolleolle
approved these changes
Dec 14, 2016
Contributor
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
This is a fine fix!
| pairs.each do |pair| | ||
| next unless pair.index('=') | ||
| variable, value = *pair.split('=') | ||
| variable, value = *pair.split('=', 2) |
benlangfeld
requested changes
Dec 14, 2016
Collaborator
benlangfeld
left a comment
benlangfeld
left a comment
There was a problem hiding this comment.
Could you add a changelog entry?
Contributor
|
Example CHANGELOG entry:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code strips everything after the first equals sign in the value of a variable set on the fly. For example,
whenever --set 'a=b=c&d=e'will set a to 'b' and d to 'e'. I noticed this when trying to pass a base64-encoded value that had trailing equals signs which were all stripped off.This patch fixes this stripping by interpreting everything after the first equals sign in a key-value pair as the value.