fix: restore dmg-background-coderm.tiff required by DMG build#226
Merged
Conversation
This file was removed in #224 under the incorrect assumption that it was an unused dead asset (product.json quality=stable). However, the release CI builds with VSCODE_QUALITY=coderm, and create-dmg.ts loads dmg-background-${quality}.tiff at line 163 — so this file is required. Its absence broke the macOS DMG build in the v1.122.0-coderm.0.26.0 release. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the macOS DMG build failure in the v1.122.0-coderm.0.26.0 release CI:
Root cause
dmg-background-coderm.tiffwas removed in #224 under the incorrect assumption that it was an unused dead asset (product.jsonhasquality: "stable").However:
.github/workflows/release.yml:75) builds withVSCODE_QUALITY: codermbuild/darwin/create-dmg.ts:163loadsdmg-background-${quality}.tiffSo
product.json'squalityis irrelevant — the CI overrides it via theVSCODE_QUALITYenv var. The file was required and its absence broke macOS DMG packaging.Fix
Restore
dmg-background-coderm.tifffrom2eeacd615e0(last commit before #224's deletion).