Don't set self.string or self.stream = nil in dealloc if they are already nil. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
already nil. There are custom setters in PKReader that assert that the counterpart field is nil. This means that we're guaranteed to assert if PKTokenizer.dealloc is ever called because one or other of these fields will be set during init. I don't understand why I'm the only one who's hitting this. Is no-one else freeing their parsers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are custom setters in PKReader that assert that the counterpart field
is nil. This means that we're guaranteed to assert if PKTokenizer.dealloc
is ever called because one or other of these fields will be set during init.
I don't understand why I'm the only one who's hitting this. Is no-one
else freeing their parsers?