feat(core): accept custom-generated colors in component inputs#693
Open
giulio-leone wants to merge 2 commits into
Open
feat(core): accept custom-generated colors in component inputs#693giulio-leone wants to merge 2 commits into
giulio-leone wants to merge 2 commits into
Conversation
Extend all color type aliases (AlertColor, ButtonColor, CalloutColor,
ChipColor, ProgressBarColor, BadgeColor, TableColor, IconColor) with
`| (string & {})` to allow custom Bootstrap Italia auto-generated
colors (primary-a1, analogue-1-a2, etc.) while preserving IDE
autocomplete for the well-known values.
Closes italia#564
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Show (string & {}) pattern allowing custom CSS-generated colors
alongside predefined theme colors. Demonstrates teal and indigo
custom colors with the generated alert-* class.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@giulio-leone is attempting to deploy a commit to the dip-trasformazione-digitale Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@giulio-leone questa modifica si applica trasversalmente a tutti i componenti? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #564
Extends all color type aliases to accept Bootstrap Italia auto-generated color tokens (e.g.
primary-a1,primary-a2,analogue-1-a1,analogue-2-a2) alongside the fixed color set.Problem
Bootstrap Italia generates custom color tokens via HSB triads (docs), but the Angular kit's color types only accepted the fixed set (
primary,secondary, etc.), causing TypeScript errors when using generated colors.Solution
Add
| (string & {})to each color type alias:AlertColor,ButtonColor,CalloutColor,ChipColorProgressBarColor,BadgeColor,TableColor,IconColorThis TypeScript pattern:
Tests
primary-a1,analogue-1-a2)