feat(gap): add itGap, itGapX, itGapY directives for CSS gap control (#580)#688
Open
giulio-leone wants to merge 1 commit into
Open
feat(gap): add itGap, itGapX, itGapY directives for CSS gap control (#580)#688giulio-leone wants to merge 1 commit into
giulio-leone wants to merge 1 commit into
Conversation
…talia#580) - Create ItGapDirective, ItGapXDirective, ItGapYDirective as standalone directives that apply real CSS gap, column-gap, and row-gap properties - Use Bootstrap Italia spacer scale (0-5) mapped to standard rem values - Enable gap on any flex/grid container without requiring .row/.col wrappers - Add 7 tests covering all directives and combined axis usage - Export all three directives from public_api.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@simionato-ennovaresearch this is the active successor to #644 and it already includes the follow-up you asked for there: both the Angular-friendly directive API and the plain CSS class path, with examples/docs. Current checks are green. If the approach looks right now, I would appreciate a review on this open PR rather than on the closed predecessor. Thanks! |
Member
|
@valeriocomo it wasn't really a problem, I added this comment afterwards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #580
Problem
Bootstrap Italia's
.g-*,.gx-*,.gy-*classes only set CSS variables consumed by the.rowclass, forcing developers to use row/column wrappers for simple flex gap spacing.Solution
Add three standalone Angular directives that apply real CSS gap properties:
[itGap]gap[itGapX]column-gap[itGapY]row-gapAll directives use Bootstrap Italia's spacer scale (0-5):
Usage:
Testing
Checklist
itenforcedpublic_api.ts