feat(text-transform): add itTextTransform directive with text-none support (#600)#687
Open
giulio-leone wants to merge 1 commit into
Open
feat(text-transform): add itTextTransform directive with text-none support (#600)#687giulio-leone wants to merge 1 commit into
giulio-leone wants to merge 1 commit into
Conversation
…pport (italia#600) - Create ItTextTransformDirective as standalone directive that controls the CSS text-transform property via @HostBinding('style.text-transform') - Support all standard values: none, capitalize, uppercase, lowercase, full-width, full-size-kana - Default to 'none' when directive is used without explicit value - Add 5 tests covering all common values and default behavior - Export from public_api.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@simionato-ennovaresearch this is the active successor to #643 and it already includes the follow-up you asked for there: both the Angular-friendly directive API and the plain CSS/docs/examples path. Current build/tests are green. The only red check is lint-commits, but its log shows a Docker pull auth/rate-limit failure on If the approach looks right now, I would appreciate a review on this open PR rather than on the closed predecessor. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #600
Problem
Bootstrap Italia generates
.text-lowercase,.text-uppercase, and.text-capitalizeutility classes, but omits.text-none(text-transform: none), forcing developers to manually add it instyles.scss.Solution
Add a standalone
ItTextTransformDirectivethat binds to[itTextTransform]and controls the CSStext-transformproperty via@HostBinding('style.text-transform').Supported values:
'none' | 'capitalize' | 'uppercase' | 'lowercase' | 'full-width' | 'full-size-kana'Usage:
Testing
Checklist
itenforcedpublic_api.ts