fix(tab-container): align vertical tabs with Bootstrap Italia design specs#678
Open
giulio-leone wants to merge 1 commit into
Open
fix(tab-container): align vertical tabs with Bootstrap Italia design specs#678giulio-leone wants to merge 1 commit into
giulio-leone wants to merge 1 commit into
Conversation
…specs - Add aria-orientation="vertical" to tablist when vertical=true (a11y) - Add verticalBackground input for nav-tabs-vertical-background class - Fix column sizing: use iconText input (not inverted) to determine wider columns (col-5/col-md-4/col-lg-3 vs col-4/col-md-3) - Text-only vertical tabs use col-4/col-md-3 per BI docs - Icon+text vertical tabs use col-5/col-md-4/col-lg-3 per BI docs - Add 16 comprehensive tests for vertical layout, columns, background, aria, and inverted modes Closes italia#568 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #568
Problem
The
ItTabContainerComponentvertical mode did not match the Bootstrap Italia design specifications:aria-orientation="vertical"on the<ul role="tablist">element (a11y)verticalBackgroundinput — Bootstrap Italia supportsnav-tabs-vertical-backgroundfor active tab background stylinginvertedinstead oficonText, so text-only vertical tabs got wrong widthsFix
aria-orientation="vertical"attribute whenvertical=trueverticalBackgroundboolean input that appliesnav-tabs-vertical-backgroundclassiconText:col-4 col-md-3/col-8 col-md-9(per BI docs)col-5 col-md-4 col-lg-3/col-7 col-md-8 col-lg-9(per BI docs)Tests
16 new tests covering:
verticalBackgroundclass applicationaria-orientationattribute presence/absence127/127 tests passing, 0 lint errors.