Skip to content

Fix solid earth tides computation fail when frequencyA is missing #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xhuang-jpl merged 29 commits into from
Apr 14, 2026
+11 −3
Merged

Fix solid earth tides computation fail when frequencyA is missing #243

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
da95af1
sm r3.4
Sep 19, 2023
3a8e2ec
merge R4.0.2beta-1
Mar 11, 2024
b6cfbbb
change the SM commit id for R4.0.2
May 23, 2024
f764f2f
merge upstream develop branch
Jun 4, 2024
a920ae6
Merge remote-tracking branch 'upstream/develop' into develop
Jun 5, 2024
1d28fae
Merge remote-tracking branch 'upstream/develop' into develop
Jun 13, 2024
84f3874
Merge remote-tracking branch 'upstream/develop' into develop
Aug 12, 2024
2bb897a
Merge remote-tracking branch 'upstream/develop' into develop
Sep 14, 2024
da76f88
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Oct 2, 2024
6313217
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Oct 9, 2024
ce2b301
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Oct 15, 2024
8394511
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Oct 24, 2024
72645bd
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Oct 29, 2024
6f93fd3
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Dec 9, 2024
eebd988
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Jan 21, 2025
9b108ce
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Jan 29, 2025
b1c78f7
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Mar 18, 2025
e46f53f
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Apr 10, 2025
54d6ab4
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
May 12, 2025
73b6b9b
Merge branch 'develop' of https://github-fn.jpl.nasa.gov/isce-3/isce …
Jun 10, 2025
2eb1387
Merge branch 'develop' of https://github.com/isce-framework/isce3 int…
Sep 30, 2025
42f2514
Merge branch 'develop' of https://github.com/isce-framework/isce3 int…
Nov 14, 2025
39c9883
Merge branch 'develop' of https://github.com/isce-framework/isce3 int…
Dec 1, 2025
f6cfd55
Merge branch 'develop' of https://github.com/isce-framework/isce3 int…
Jan 14, 2026
6176caa
Merge branch 'develop' of https://github.com/isce-framework/isce3 int…
Jan 16, 2026
1f111b3
Merge branch 'develop' of https://github.com/isce-framework/isce3 int…
Mar 23, 2026
2ac16f7
fix the frequency bug
Mar 23, 2026
a6dbede
fix typos
Mar 23, 2026
54dba04
add the comments
Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions python/packages/nisar/workflows/solid_earth_tides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,17 @@ def _extract_ref_epoch(ds_name: str):
projection_dataset = h5_obj[f'{rdr_grid_path}/projection']
epsg = projection_dataset.attrs['epsg_code']

# Wavelength in meters
wavelength = isce3.core.speed_of_light / \
h5_obj[f'{gunw_obj.GridsPath}/frequencyA/centerFrequency'][()]
# Wavelength in meters; fall back to frequencyB if frequencyA is not found
for freq in ('A', 'B'):
Copy link
Copy Markdown
Contributor

@Tyler-g-hudson Tyler-g-hudson Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we capture first available of A or B instead of calculating a different datacube for each? They would have different values, wouldn't they?

Copy link
Copy Markdown
Contributor Author

@xhuang-jpl xhuang-jpl Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question @Tyler-g-hudson, for NISAR InSAR processing, we are always processing frequencyA even if the product has both freqA and freqB. This fix is for users who need to process the freqB stand alone.

Copy link
Copy Markdown
Contributor

@Tyler-g-hudson Tyler-g-hudson Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've understood that part - what I mean to ask is why we have selected to do that when the values might be different between two different data cubes, is it because we only expect people to use it for the primary frequency?

Copy link
Copy Markdown
Contributor Author

@xhuang-jpl xhuang-jpl Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always expect people use the frequencyA as the primary at least for the NISAR.

if (key := f'{gunw_obj.GridsPath}/frequency{freq}/centerFrequency') in h5_obj:
wavelength = isce3.core.speed_of_light / h5_obj[key][()]
break
else:
err_msg = (
f"Neither 'frequencyA' nor 'frequencyB' centerFrequency found "
f"in '{gunw_obj.GridsPath}' for solid earth tides computation")
err_channel.log(err_msg)
raise KeyError(err_msg)

return (inc_angle_cube,
los_unit_vector_x_cube,
Expand Down
Loading