feat(iosxr): Implement VRF provider#344
Open
sven-rosenzweig wants to merge 2 commits into
Open
Conversation
hardikdr
added
the
area/switch-automation
sven-rosenzweig
force-pushed
the
vrf
branch
2 times, most recently
from
852053e to
d04980e
Compare
felix-kaestner
approved these changes
May 13, 2026
Comment on lines
+66
to
+67
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit: you pipe this one through jq once for formatting?
Comment on lines
+389
to
+392
| if p.client == nil { | ||
| return errors.New("client is not connected") | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
You typically wouldn't check this for nil.
| case v1alpha1.IPv6: | ||
| AppendAddressFamily(&vrf.AddrFamily.IPv6.Unicast, rt, routeTarget.Action) | ||
| default: | ||
| return fmt.Errorf("unsupported address family %q for VRF %q", af, req.VRF.Spec.Name) |
Contributor
There was a problem hiding this comment.
If you want, you can make use of the apistatus package in #325 (just needs a review).
Contributor
Author
There was a problem hiding this comment.
Reviewed the PR, will make the change for IOS-XR at once. So leave this here as is.
Adds basic VRF configuration support for IOS-XR routers. Follow-ups: * Set interfaces as member of the VRF * Add support for 2-byte and IPv4 route targets Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
Signed-off-by: Sven Rosenzweig <sven.rosenzweig@sap.com>
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic VRF configuration support for IOS-XR routers.
Follow-ups: