Evaluate sparse ELL1 FB derivatives and reject inactive DDGR FB terms - #8
Open
vhaasteren wants to merge 1 commit into
Open
Evaluate sparse ELL1 FB derivatives and reject inactive DDGR FB terms#8vhaasteren wants to merge 1 commit into
vhaasteren wants to merge 1 commit into
Conversation
Activate the ELL1 higher-FB phase branch when any FB1+ coefficient is present, use PBDOT as the missing FB1 coefficient, and reject inactive FB parameters in DDGR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PINT companion PR
Companion PINT PR: nanograv/PINT#2023
Overview
This addresses #6
ELL1 represents the accumulated number of binary orbits as:
with:
when the constant and first derivative are supplied through
PBandPBDOT.The current ELL1 implementation uses the presence of
FB1(
paramSet[1]) as a sentinel for the entire higher-FB branch. As a result:PB + FB2silently ignoresFB2;PB + PBDOT + FB2applies PBDOT but silently ignoresFB2;FB0 + FB2silently ignoresFB2.That does not follow the Taylor series. A missing interior coefficient is
zero; it must not disable explicitly supplied higher coefficients.
This PR activates ELL1's higher-FB branch when any
FBn,n >= 1, ispresent. Within that branch the quadratic coefficient is selected as:
Every supplied
FB2+coefficient is then evaluated with the existingfactorial convention. The implementation retains PB/PBDOT as tempo2
parameters; it does not rewrite the par file or synthesize stored zero
coefficients.
When both PBDOT and explicit FB1 are supplied for ELL1, explicit FB1 takes
precedence. Tempo2 now warns and disables PBDOT, including its fit flag.
This is necessary for model consistency: the old forward phase ignored
PBDOT in that configuration while the analytic PBDOT derivative remained
nonzero. PBDOT remains active, with its existing derivative, when FB1 is
absent and sparse FB2+ terms are present.
Normal contiguous models are unchanged. In particular, PPTA DR2/DR3
J2241−5236 uses
PB + FB1...FB17and already enters the higher-FB branch,so its nominal timing remains unchanged.
This PR also rejects any FB parameter used with
BINARY DDGR.DDGRmodel.Cobtains its orbital period, mean motion, GR post-Keplerianquantities, phase, and derivatives from PB and never reads
param_fb.Previously, DDGR pars could therefore contain FB parameters that had no
effect. The new error is a validation change, not an implementation of
DDGR+FB.
Correct DDGR+FB support requires a single dynamic PB/FB source of truth and
derivatives including:
That larger physics change is outside this PR.
Other binary models are deliberately unchanged. In particular, this PR does
not add a general rejection rule for FB lines accepted but unused by DD, BT,
ELL1H, or other models. Its validation scope is limited to the two behaviors
covered by the companion PINT work: sparse ELL1 FB evaluation and explicit
DDGR rejection.
Tests cover:
PB + FB2;PB + PBDOT + FB2;FB0 + PBDOT + FB2;PB + FB1 + FB3;FB0 + FB2;This is the tempo2 companion to the PINT PR linked above, which implements
canonical hybrid/sparse FB-series normalization. Both implementations now
evaluate the same nominal sparse ELL1 phase while retaining their native
parameter representations.