Cur Client scanner module#4
Open
klomlk wants to merge 9 commits into
Open
Conversation
|
The linter rejects the format of commit messages and pull request title. |
npochic
reviewed
Sep 26, 2025
npochic
left a comment
npochic
left a comment
There was a problem hiding this comment.
some files are marked as changed but I do not see the difference?
| # Required variables | ||
| kms_key_arn = "arn:aws:kms:eu-west-3:992382519845:key/f4ab6c91-0a7d-4a32-8c11-8fdd4380888d" | ||
| aws_org_id = "o-yn7toj4ob7" | ||
| cur_output_bucket_name = "iroco-cur-bucket-toto" |
There was a problem hiding this comment.
Suggested change
| cur_output_bucket_name = "iroco-cur-bucket-toto" | |
| cur_output_bucket_name = "iroco-cur-bucket-example" |
avoid toto?
Comment on lines
+5
to
+14
| kms_key_arn = "arn:aws:kms:eu-west-3:992382519845:key/02094aa9-afab-4e3c-84b2-8082380c66eb" | ||
| layer_bucket_storage = "iroco-test-sylvain-scrapper" | ||
| layer_bucket_key = "layers/helper-scripts.zip" | ||
| aws_org_id = "o-yn7toj4ob7" | ||
| cur_output_bucket_name = "iroco-cur-bucket" | ||
| cur_function_s3_key = "functions/cur-scanner.zip" | ||
| cur_function_s3_bucket = "iroco-test-sylvain-scrapper" | ||
| iroco2_api_endpoint = "https://api.iroco2.example.com" | ||
| iroco2_gateway_endpoint = "https://gateway.iroco2.example.com" | ||
| iroco2_api_key = "your-api-key-here" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Merge a working module for lambda client side scanner
Reference issues or tasks
...
Checklist