-
Notifications
You must be signed in to change notification settings - Fork 13.4k
refactor(core): use Capacitor safe-area CSS variables on older WebViews #30866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm marking this as a refactor so it doesn't show up in the Changelog twice since the fix was made on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this test uses the legacy Picker and the ionic theme does not have styles for it so this is expected: https://ionic-framework-git-fw-6987-next-ionic1.vercel.app/src/components/app/test/safe-area?ionic:theme=ionic
Issue number: internal
What is the current behavior?
The safe area variables are only reliant on
envvariables that are provided by devices.What is the new behavior?
Capacitor 8 has released safe area variable fallbacks to provide consistent behaviors with older Android devices:
Does this introduce a breaking change?
Other information
Changes to the core file will be done on
main.