Migration to zim#9
Conversation
The previous version of InstantSHELL was dependent on antidote, this one has been adapted to use zim.
|
Thank you so much for the contribution 😄 |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the shell configuration from using antidote to zim as the plugin manager. The migration involves updating the configuration files, installation/uninstallation scripts, and documentation to reflect the change from antidote to zim.
- Replaced antidote plugin manager references with zim throughout the codebase
- Updated installation and uninstallation procedures to handle zim-specific files and directories
- Modified plugin loading mechanism to use zim's approach instead of antidote's
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| zshrc | Updates plugin installation function and sourcing mechanism for zim |
| zimrc | Removes InstantOS plugin from zim configuration |
| instantshell.sh | Replaces antidote commands with zim equivalents in install/uninstall/update operations |
| README.md | Updates documentation to reference zim instead of antidote |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| source "${ZIM_HOME}/init.zsh" | ||
| } | ||
|
|
||
| source "${ZIM_HOME}/init.zsh" |
There was a problem hiding this comment.
The source "${ZIM_HOME}/init.zsh" command is executed outside the install_zim_plugins() function, but ZIM_HOME may not be set. This could cause the script to fail if ZIM_HOME is undefined. Consider setting a default value for ZIM_HOME or moving this line inside the function where the zim installation logic handles the variable.
| source "${ZIM_HOME}/init.zsh" |
| exit 1 | ||
| fi | ||
| ;; | ||
| "update") |
There was a problem hiding this comment.
[nitpick] The update operation runs both zimfw update and zimfw upgrade sequentially. Consider clarifying the purpose of each command in a comment, as the distinction between 'update' and 'upgrade' in zim context may not be immediately clear to maintainers.
| "update") | |
| "update") | |
| # Run both 'zimfw update' (to update plugins and themes) and 'zimfw upgrade' (to update the Zim framework itself). |
I've adapted the previous functions to now use zim instead of antidote.