Disabling log collection at the tracer level#768
Merged
Conversation
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
log_disabling
branch
2 times, most recently
from
e3c5c1c to
5bc5e21
Compare
GSVarsha
reviewed
Jul 30, 2025
GSVarsha
reviewed
Jul 30, 2025
GSVarsha
reviewed
Jul 30, 2025
GSVarsha
reviewed
Jul 30, 2025
The span disabling allows the exclusion of specific traces or calls from tracing based on the category (technology) or type (frameworks, libraries, instrumentations) supported by the traces. This commit adds support to handle the configuration from the INSTANA_TRACING_DISABLE, INSTANA_CONFIG_PATH, and Agent-provided configuration. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Disabling log spans collection at the tracer level to prevent duplication in the backend when both the application tracer and an OpenTelemetry collector are running on the same system. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
GSVarsha
reviewed
Jul 30, 2025
GSVarsha
reviewed
Jul 30, 2025
The `INSTANA_DISABLE` is not a general environment variable from Instana, and with the adoption of the new `INSTANA_TRACING_DISABLE` we can have the same effect. So this commit removes the legacy one. Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to disable log collection at the tracer level to prevent duplication in the backend when both the application tracer and an OpenTelemetry collector are running on the same system.
This PR adds support for the Span Disabling feature, which allows the exclusion of specific traces or calls from tracing based on the category (technology) or type (frameworks, libraries, instrumentations) supported by the traces.
In addition, it refactors the initialization of the Instana module and the ConfigReader class.