fix: Prevent internal span creation when root exit variable is set#729
Closed
CagriYonca wants to merge 1 commit into
Closed
fix: Prevent internal span creation when root exit variable is set#729CagriYonca wants to merge 1 commit into
CagriYonca wants to merge 1 commit into
Conversation
Signed-off-by: Cagri Yonca <cagri@ibm.com>
pvital
reviewed
May 7, 2025
| if ( | ||
| tracing_is_off() | ||
| or (span_name == "boto3") | ||
| or (agent.options.allow_exit_as_root and "com.instana" in kwargs.get("url")) |
Member
There was a problem hiding this comment.
That works, but it will block all spans pointing to any URL containing "com.instana", and this can cause missing spans in the future.
Why not revisit the PR #562 and supress all internal calls?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal spans are being created by internal http calls of the host. I've adapted urllib3 to prevent this issue.