ci: Add rerun failures package for flaky tests#728
Closed
CagriYonca wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Contributor
Author
|
Grpcio fails randomly:
def test_server_error(self) -> None:
response = None
with tracer.start_as_current_span("test"):
try:
response = self.server_stub.OneQuestionOneErrorResponse(
stan_pb2.QuestionRequest(question="Do u error?")
)
except Exception:
pass
assert not get_current_span().is_recording()
assert not response
spans = self.recorder.queued_spans()
> assert len(spans) == 4
E assert 3 == 4 |
Contributor
Author
|
Tornado fails randomly:
def test_get_with_params_to_scrub(self) -> None:
async def test():
with tracer.start_as_current_span("test"):
async with aiohttp.ClientSession() as session:
return await self.fetch(session, testenv["tornado_server"], params={"secret": "yeah"})
response = tornado.ioloop.IOLoop.current().run_sync(test)
spans = self.recorder.queued_spans()
> assert len(spans) == 3
E AssertionError: assert 2 == 3 |
Contributor
Author
|
Not needed anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm taking the initiative and proposing the
pytest-rerunfailurespackage for flaky tests. Only thing we should do is to add the line just before flaky tests: