feat: Kafka FUP Phase I and Phase II#718
Merged
Merged
Conversation
GSVarsha
reviewed
Apr 14, 2025
GSVarsha
reviewed
Apr 14, 2025
GSVarsha
reviewed
Apr 14, 2025
GSVarsha
reviewed
Apr 14, 2025
e834b59 to
07cc254
Compare
Member
|
@CagriYonca, please work on the #721 first, and after it is merged, we can finalize this one and the following one. |
d8d36f2 to
b79ab06
Compare
pvital
requested changes
May 7, 2025
Member
pvital
left a comment
There was a problem hiding this comment.
Few requests.
I am missing some tests for the new functions or environment variables to be parsed, as the INSTANA_IGNORE_ENDPOINTS_PATH.
634b521 to
b01bf7a
Compare
4bc4eb6 to
e1383d4
Compare
Signed-off-by: Cagri Yonca <cagri@ibm.com>
Signed-off-by: Cagri Yonca <cagri@ibm.com>
pvital
approved these changes
Jun 26, 2025
Member
pvital
left a comment
There was a problem hiding this comment.
It looks good to me.
Only two missing copyright headers and then you can merge it.
Signed-off-by: Cagri Yonca <cagri@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase I - Changes:
configuration.yamlfile to filter specific services and methods now, as specified in the technical specification.configuration.yamlfile has the highest priority, usesendfor kafka-python andproducefor confluent-kafka:Phase II - Changes: