feat: add --gcp-uniform-bucket-level-access flag to skip ACLs#91
Open
pushkar-anand wants to merge 1 commit into
Open
feat: add --gcp-uniform-bucket-level-access flag to skip ACLs#91pushkar-anand wants to merge 1 commit into
pushkar-anand wants to merge 1 commit into
Conversation
Collaborator
|
@pushkar-anand is this still a draft only or is this mergeable already? |
Author
|
@smiklosovic: Need to update tests. Will mark it ready once the tests are fixed. |
pushkar-anand
force-pushed
the
fix/gcs-uniform-bucket-level-access
branch
from
c361930 to
10c91af
Compare
Author
|
@smiklosovic Apologies for the long wait, the PR is ready for review. It is tested extensively and works correctly. |
Collaborator
|
@pushkar-anand can you please rebase it on top of 4.0.0 (current master branch). The plugin has gone through modularisation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configuration flag to conditionally skip setting predefined ACLs on GCS uploads when buckets have uniform bucket-level access enabled.
Fixes #89