This repository was archived by the owner on Oct 2, 2025. It is now read-only.
Transaction History Store - #16
Open
patche-v wants to merge 23 commits into
Open
Conversation
FilipNikolovski
approved these changes
Jan 22, 2020
| store := store.NewTransactionHistoryStoreModel(suite.Db) | ||
| var err error | ||
| var transact []*entities.TransactionHistory | ||
| for _, value := range suite.TransactionsP { |
Contributor
There was a problem hiding this comment.
@vpatcev18 why do we need to iterate the transactions here?
transact, err = store.GetTransactionsById(value.UserId)
This will fetch transactions multiple times for the same user ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transaction History Store