Skip to content

chore(deps): upgrade to latest alloy/sdk/trevm#99

Merged
Evalir merged 2 commits into
mainfrom
evalir/chore-deps-upgrade-to-latest-alloy-sdk-trevm
May 30, 2025
Merged

chore(deps): upgrade to latest alloy/sdk/trevm#99
Evalir merged 2 commits into
mainfrom
evalir/chore-deps-upgrade-to-latest-alloy-sdk-trevm

Conversation

@Evalir

@Evalir Evalir commented May 29, 2025

Copy link
Copy Markdown
Member

Closes ENG-1109

Evalir commented May 29, 2025

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Evalir

Evalir commented May 29, 2025

Copy link
Copy Markdown
Member Author

wonder if we should explicitly switch to the SimpleNonceManager instead of the CachedNonceManager as we did on the node?

@prestwich

Copy link
Copy Markdown
Member

we honestly want custom nonce management behavior here. so should drop it out entirely? or write our own?

@Evalir

Evalir commented May 29, 2025

Copy link
Copy Markdown
Member Author

i think we probably want to write our own, but to keep this moving, i propose:

  • switch to the previous nonce manager to keep the status quo
  • merge
  • write a custom nonce manager in another pr

Copy link
Copy Markdown
Contributor

I rebased my dylan/submit-channel-refactors branch on top of this to test it, and it compiled and ran with a cargo update && cargo build with the confirmed new alloy and trevm versions, so I'm in favor of merging now and following up nonce management with the submit refactors.

@prestwich

Copy link
Copy Markdown
Member

I rebased my dylan/submit-channel-refactors branch on top of this to test it, and it compiled and ran with a cargo update && cargo build with the confirmed new alloy and trevm versions, so I'm in favor of merging now and following up nonce management with the submit refactors.

this sounds real good to me

@Evalir Evalir merged commit 7e359c5 into main May 30, 2025
6 checks passed
@Evalir Evalir deleted the evalir/chore-deps-upgrade-to-latest-alloy-sdk-trevm branch May 30, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants