fix: use spans properly in submit task#112
Closed
dylanlott wants to merge 4 commits into
Closed
Conversation
dylanlott
force-pushed
the
dylan/fix-spans
branch
from
395d587 to
ace7f36
Compare
| .into_future() | ||
| .instrument(span.clone()) | ||
| .await | ||
| let prev_host_number = host_block_number - 1; |
Contributor
There was a problem hiding this comment.
is this a drive-by or was it related to the panic?
Contributor
Author
There was a problem hiding this comment.
It's another bug, actually, just was part of the same PR. I think it's the reason why the builder isn't submitting blocks in dev-net right now. I will build and submit this into a new PR since the span fixes are addressed in #113.
prestwich
requested changes
Jun 17, 2025
prestwich
left a comment
prestwich
left a comment
Member
There was a problem hiding this comment.
this isnt fixing, its just removing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: use spans properly in submit task
This PR fixes the panicking span in the submit task.
Previously, there was a panic caused by incorrect handling of the span in the retry loop.
Tested and confirmed that spans are tracing as expected in devnet with this fix.
This branch is deployed in dev-net at commit
415baae17f0194bb39f3f5825b9d5473f27a3ece.Closes ENG-1128