Skip to content

feat: SDK 56 - #3038

Open
frankcalise wants to merge 5 commits into
masterfrom
feat/expo-sdk-56
Open

feat: SDK 56#3038
frankcalise wants to merge 5 commits into
masterfrom
feat/expo-sdk-56

Conversation

@frankcalise

Copy link
Copy Markdown
Contributor

Description

Updates the boilerplate to use Expo SDK 56

Checklist

  • README.md and other relevant documentation has been updated with my changes
  • I have manually tested this, including by generating a new app locally (see docs).

@flexbox flexbox left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

const [scrollViewHeight, setScrollViewHeight] = useState<number | null>(null)
const [scrollViewContentHeight, setScrollViewContentHeight] = useState<number | null>(null)

function updateScrollState() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: @frankcalise - why did all of this need to change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some lint rules changed in the expo package (or just later react rules in a rule from the upgrade), so any source changes were fixing lint errors. Mostly react rules around not touching refs in render

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sure that makes sense.

@coolsoftwaretyler coolsoftwaretyler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

fdev-llc added a commit to fdev-llc/ignite that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants